Skip to content

Add results for reconfig test #1354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 8, 2023
Merged

Add results for reconfig test #1354

merged 3 commits into from
Dec 8, 2023

Conversation

kate-osborn
Copy link
Contributor

Proposed changes

Problem: We need to run the reconfig test against the 1.1 release.

Solution: Record the results of the reconfig test for the 1.1 release.

Closes #1269

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@kate-osborn kate-osborn requested a review from a team as a code owner December 8, 2023 16:15
@netlify Netlify
Copy link

netlify bot commented Dec 8, 2023 •
edited
Loading

✅ Deploy Preview for nginx-gateway-fabric canceled.

Name Link
🔨 Latest commit 2cf8313
🔍 Latest deploy log https://app.netlify.com/sites/nginx-gateway-fabric/deploys/65735b09cf2274000805c816

@github-actions github-actions bot added documentation Improvements or additions to documentation tests Pull requests that update tests labels Dec 8, 2023
@kate-osborn kate-osborn merged commit b77d74b into nginx:main Dec 8, 2023
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this pull request Jan 14, 2025
@miledxz
Add results for reconfig test (nginx#1354)
3ae13c9 
Problem: We need to run the reconfig test against the 1.1 release.

Solution: Record the results of the reconfig test for the 1.1 release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjberman sjberman sjberman approved these changes

@bjee19 bjee19 bjee19 left review comments

@pleshakov pleshakov pleshakov approved these changes

@ciarams87 ciarams87 ciarams87 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation tests Pull requests that update tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1.1 Reconfig Test
5 participants
@kate-osborn @pleshakov @sjberman @ciarams87 @bjee19