Skip to content

Fix broken links and example output #1373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 13, 2023

Conversation

kate-osborn
Copy link
Contributor

Proposed changes

Problem: Found some outdated links and incorrect output in our examples and guides.

Solution: Fix links and output.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@kate-osborn kate-osborn requested review from a team as code owners December 12, 2023 23:47
Copy link

netlify bot commented Dec 12, 2023

Deploy Preview for nginx-gateway-fabric ready!

Name Link
🔨 Latest commit 51e3850
🔍 Latest deploy log https://app.netlify.com/sites/nginx-gateway-fabric/deploys/6579d4859f91eb0008bbde7e
😎 Deploy Preview https://deploy-preview-1373--nginx-gateway-fabric.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 12, 2023
@kate-osborn kate-osborn reopened this Dec 12, 2023
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I have made two suggestions.

Copy link
Contributor

@JTorreG JTorreG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with comments

Co-authored-by: Alan Dooley <[email protected]>
@kate-osborn kate-osborn merged commit 7e075c6 into nginx:main Dec 13, 2023
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this pull request Jan 14, 2025
Problem: Outdated links and incorrect output in our examples and guides.

Solution: Fix links and output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants