Skip to content

Add telemetry job #1448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 10, 2024
Merged

Add telemetry job #1448

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c2a49b8
Add telemetry job
pleshakov Jan 5, 2024
744b402
Update internal/mode/static/manager.go
pleshakov Jan 8, 2024
d226662
Updated jitter
pleshakov Jan 8, 2024
f05598a
Update error message
pleshakov Jan 8, 2024
3050949
Update goreleaser settings
pleshakov Jan 8, 2024
bb12043
Fix YAML linting
pleshakov Jan 8, 2024
57b2576
Simplify test for Start of Job
pleshakov Jan 8, 2024
be8b4e0
Changed LeaderElectionReleaseOnCancel to false and added a comment
pleshakov Jan 8, 2024
1a27c77
Add an assertion in TestEnableAfterBecameLeader
pleshakov Jan 10, 2024
06832aa
Update minReports and extend the comment
pleshakov Jan 10, 2024
b7a40aa
Merge branch 'main' into feature/telemetry-job
pleshakov Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update minReports and extend the comment
  • Loading branch information
@pleshakov
pleshakov committed Jan 10, 2024
commit 06832aab238fdae14401456a03bc76ab8733da35
2 changes: 1 addition & 1 deletion internal/mode/static/telemetry/job_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ var _ = Describe("Job", func() {
close(errCh)
}()

const minReports = 3 // ensure that the Job reports at least this many times
const minReports = 2 // ensure that the Job reports more than once: it doesn't exit after the first report

Eventually(exporter.ExportCallCount).Should(BeNumerically(">=", minReports))
for i := 0; i < minReports; i++ {
Expand Down