Skip to content

Add telemetry job #1448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 10, 2024
Prev Previous commit
Next Next commit
Update minReports and extend the comment
  • Loading branch information
pleshakov committed Jan 10, 2024
commit 06832aab238fdae14401456a03bc76ab8733da35
2 changes: 1 addition & 1 deletion internal/mode/static/telemetry/job_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ var _ = Describe("Job", func() {
close(errCh)
}()

const minReports = 3 // ensure that the Job reports at least this many times
const minReports = 2 // ensure that the Job reports more than once: it doesn't exit after the first report

Eventually(exporter.ExportCallCount).Should(BeNumerically(">=", minReports))
for i := 0; i < minReports; i++ {
Expand Down