Skip to content

Collect Deployment Flag Options #1578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 28, 2024
Merged

Collect Deployment Flag Options #1578

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3c66f9a
Add initial draft of flag options
bjee19 Feb 13, 2024
2187af7
Add different Deployment Flag Options
bjee19 Feb 14, 2024
1c8cf8b
Add temporary collector tests
bjee19 Feb 14, 2024
402d2a0
WIP
bjee19 Feb 15, 2024
17deecc
Move flag parsing to commands
bjee19 Feb 16, 2024
f936282
Change comment wording
bjee19 Feb 16, 2024
95c4653
Fix lint issues
bjee19 Feb 16, 2024
89e9531
Add some review feedback
bjee19 Feb 23, 2024
9c405e1
Fix rebasing issue
bjee19 Feb 23, 2024
449adb0
Add review feedback
bjee19 Feb 23, 2024
3220c93
Fix declaration of flag slices
bjee19 Feb 26, 2024
60ac78b
Refactor code to remove else statement
bjee19 Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix declaration of flag slices
  • Loading branch information
@bjee19
bjee19 committed Feb 28, 2024
commit 3220c93ef2bd17eb4c4a3c10e4ac3d958a35fb08
5 changes: 2 additions & 3 deletions cmd/gateway/commands.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,9 +458,8 @@ func createSleepCommand() *cobra.Command {
return cmd
}

func parseFlags(flags *pflag.FlagSet) (flagKeys, flagValues []string) {
flagKeys = []string{}
flagValues = []string{}
func parseFlags(flags *pflag.FlagSet) ([]string, []string) {
var flagKeys, flagValues []string

flags.VisitAll(
func(flag *pflag.Flag) {
Expand Down