Use chart-testing to lint the Helm Chart #2027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
chore
lucacome
force-pushed
the
chore/helm
branch
2 times, most recently
from
c72c3f8 to
ef63773
Compare
Problem: We want to validate all the files related to the helm chart and not just run helm lint Solution: Use helm/chart-testing
sjberman
reviewed
May 29, 2024
kate-osborn
approved these changes
May 29, 2024
salonichf5
reviewed
May 29, 2024
|
This log in the pipeline run: |
|
yeah it prints the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2027 +/- ##
=======================================
Coverage 87.61% 87.61%
=======================================
Files 96 96
Lines 6694 6694
Branches 50 50
=======================================
Hits 5865 5865
Misses 773 773
Partials 56 56 ☔ View full report in Codecov by Sentry. |
sjberman
approved these changes
May 30, 2024
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
Use chart-testing to lint the Helm Chart Problem: We want to validate all the files related to the helm chart and not just run helm lint Solution: Use helm/chart-testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: We want to validate all the files related to the helm chart and not just run helm lint
Solution: Use helm/chart-testing
Closes #2043
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.