Skip to content

Automate remaining graceful recovery tests #2140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
28c753d
Automate remaining graceful recovery tests
bjee19 Jun 12, 2024
6b039b8
Remove debugging statements
bjee19 Jun 17, 2024
0ea4682
Run pipeline with failing test
bjee19 Jun 17, 2024
1971d96
Revert the test to make it work
bjee19 Jun 17, 2024
4b31588
Run pipeline
bjee19 Jun 20, 2024
7f52961
Run pipeline with failing test
bjee19 Jun 20, 2024
ea8fa3d
Remove manual test document
bjee19 Jun 20, 2024
b104e2b
Run pipeline
bjee19 Jun 20, 2024
f7932bb
Add separate functions for draining and abrupt restart tests
bjee19 Jun 20, 2024
9ad9fb8
Add review feedback
bjee19 Jun 20, 2024
23f6ff0
Refactor docker inspect command
bjee19 Jun 21, 2024
d145601
Use cluster name passed in from flag
bjee19 Jun 21, 2024
5c26b39
Add cluster name flag to right make command
bjee19 Jun 21, 2024
a19bce4
Correct flag name
bjee19 Jun 21, 2024
e752d21
Remove comments
bjee19 Jun 21, 2024
dd25200
Rebase with fixes to skipped failing tests
bjee19 Jun 24, 2024
c79b644
Teardown NGF between each test
bjee19 Jun 24, 2024
3d2151b
Run pipeline
bjee19 Jun 24, 2024
71affc5
Use BeEmpty instead of empty string
bjee19 Jun 24, 2024
7fe4691
Remove functional label
bjee19 Jun 24, 2024
53a6529
Add stable readiness check
bjee19 Jun 25, 2024
43597ad
Add back in extended timeout
bjee19 Jun 25, 2024
666f35f
Extend timout duration for waiting on NGF
bjee19 Jun 25, 2024
13ae858
Add skip if test is running on GKE
bjee19 Jun 25, 2024
88ac69a
Increase stable readiness count
bjee19 Jun 25, 2024
1a7027f
Adjust readiness count
bjee19 Jun 25, 2024
4c305d0
Update comment
bjee19 Jun 26, 2024
bb392b1
Add nil check for clusterName
bjee19 Jun 26, 2024
9769303
Adjust wording on error
bjee19 Jun 26, 2024
18d153b
Add MustPassRepeatedly to Eventually check
bjee19 Jun 26, 2024
9370b25
Move checks on clusterName earlier
bjee19 Jun 26, 2024
df28aa1
Re-run pipeline
bjee19 Jun 26, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add nil check for clusterName
  • Loading branch information
bjee19 committed Jun 26, 2024
commit bb392b188def28421b3791e0931dcf7a96f5913b
1 change: 1 addition & 0 deletions tests/suite/graceful_recovery_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ func runRestartNodeTest(teaURL, coffeeURL string, files []string, ns *core.Names
Expect(err).ToNot(HaveOccurred())
}

Expect(clusterName).ToNot(BeNil(), "clusterName variable not set")
Expect(*clusterName).ToNot(BeEmpty())
containerName := *clusterName + "-control-plane"

Expand Down