Skip to content

Use yamllint action from reviewdog #2186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Use yamllint action from reviewdog #2186

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f903da8
Use yamllint action from reviewdog
lucacome Jul 1, 2024
065c6ec
Merge branch 'main' into chore/yamllint
lucacome Jul 1, 2024
9cec8e2
Merge branch 'main' into chore/yamllint
lucacome Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Use yamllint action from reviewdog 
Problem: We manually install yamnllint without controlling the version

Solution: Use an action-yamllint so we can pin the version and also get
annotations
  • Loading branch information
@lucacome
lucacome committed Jul 1, 2024
commit f903da8ce00c4ae216b684a249926e9168bf760f
23 changes: 11 additions & 12 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ permissions:

jobs:
lint:
name: Lint
name: Go Lint
runs-on: ubuntu-22.04
strategy:
fail-fast: false
Expand All @@ -36,10 +36,9 @@ jobs:
with:
go-version: stable

- name: Lint Code
- name: Lint Go
uses: golangci/golangci-lint-action@a4f60bb28d35aeee14e6880718e0c85ff1882e64 # v6.0.1
with:
args: --timeout 10m0s
working-directory: ${{ matrix.directory }}

njs-lint:
Expand Down Expand Up @@ -82,7 +81,8 @@ jobs:
- name: Checkout Repository
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7

- uses: reviewdog/action-actionlint@afad3b6ab835e5611bda8c8193377e2d5c21413d # v1.51.0
- name: Lint Actions
uses: reviewdog/action-actionlint@afad3b6ab835e5611bda8c8193377e2d5c21413d # v1.51.0
with:
actionlint_flags: -shellcheck ""

Expand All @@ -93,10 +93,12 @@ jobs:
- name: Checkout Repository
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7

- uses: DavidAnson/markdownlint-cli2-action@b4c9feab76d8025d1e83c653fa3990936df0e6c8 # v16.0.0
- name: Lint Markdown
uses: DavidAnson/markdownlint-cli2-action@b4c9feab76d8025d1e83c653fa3990936df0e6c8 # v16.0.0
with:
config: ${{ github.workspace }}/.markdownlint-cli2.yaml
config: .markdownlint-cli2.yaml
globs: "**/*.md"
fix: false

chart-lint:
name: Chart Lint
Expand All @@ -120,14 +122,11 @@ jobs:
run: ct lint --print-config --config .ct.yaml

yaml-lint:
name: Yaml Lint
name: YAML lint
runs-on: ubuntu-22.04
steps:
- name: Checkout Repository
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7

- name: Install yamllint
run: pip install yamllint

- name: Lint YAML files
run: yamllint .
- name: Lint YAML
uses: reviewdog/action-yamllint@508148c0d959b166798f9792d1b29dddcac37348 # v1.16.0
Loading