Skip to content

Watch SnippetsFilters when feature is enabled and add to graph #2519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 9, 2024
Merged

Watch SnippetsFilters when feature is enabled and add to graph #2519

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2459135
Watch SnippetsFilters when feature is enabled
Sep 5, 2024
3d9ec19
Remove duplicate log
Sep 6, 2024
4f7d822
Add comment and fix alignment
Sep 6, 2024
61dffdf
Update CRD validation
Sep 6, 2024
ef188b4
Add more validation and tests
Sep 6, 2024
69f8ddc
Remove unnecessary minLength
Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove duplicate log
  • Loading branch information
Kate Osborn committed Sep 6, 2024
commit 3d9ec1956b4ebad3a76f2507ea975eff0e512c7d
2 changes: 0 additions & 2 deletions internal/mode/static/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@
updateGatewayClassStatus: cfg.UpdateGatewayClassStatus,
})

objects, objectLists := prepareFirstEventBatchPreparerArgs(cfg)

Check warning on line 244 in internal/mode/static/manager.go

View check run for this annotation

Codecov / codecov/patch

internal/mode/static/manager.go#L244 

Added line #L244 was not covered by tests

firstBatchPreparer := events.NewFirstEventBatchPreparerImpl(mgr.GetCache(), objects, objectLists)
eventLoop := events.NewEventLoop(
Expand Down Expand Up @@ -530,17 +530,15 @@
}
}

if cfg.SnippetsFilters {
cfg.Logger.V(1).Info("Registering controller for SnippetsFilter")

controllerRegCfgs = append(controllerRegCfgs,
ctlrCfg{
objectType: &ngfAPI.SnippetsFilter{},
options: []controller.Option{
controller.WithK8sPredicate(k8spredicate.GenerationChangedPredicate{}),
},
},
)

Check warning on line 541 in internal/mode/static/manager.go

View check run for this annotation

Codecov / codecov/patch

internal/mode/static/manager.go#L533-L541 

Added lines #L533 - L541 were not covered by tests
}

for _, regCfg := range controllerRegCfgs {
Expand Down
Loading