Skip to content

Only set stream status zone if hostname exists #2684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Only set stream status zone if hostname exists #2684

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Only set stream status zone if hostname exists 
Problem: Noticed during conformance tests, the stream server blocks did not have a hostname, and therefore the status_zone value was empty and invalid.

Solution: Only set the status_zone directive if it has a value.
  • Loading branch information
@sjberman
sjberman committed Oct 11, 2024
commit 7e87ef62aa34f0aa24b9b83e4a387b4743f6a997
2 changes: 1 addition & 1 deletion internal/mode/static/nginx/config/stream_servers_template.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ server {
{{- range $address := $s.RewriteClientIP.RealIPFrom }}
set_real_ip_from {{ $address }};
{{- end}}
{{- if $.Plus }}
{{- if and $.Plus $s.StatusZone }}
status_zone {{ $s.StatusZone }};
{{- end }}

Expand Down
Loading