Skip to content

Watch UpstreamSettingsPolicies and translate into dataplane configuration #2887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 13, 2024
Merged

Watch UpstreamSettingsPolicies and translate into dataplane configuration #2887

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
045d7da
Watch UpstreamSettingsPolicies and translate into datplane config
Dec 10, 2024
d3a46a2
Update generated docs
Dec 11, 2024
ce0a999
Fix typos
Dec 11, 2024
8c8f66a
Remove int validation
Dec 11, 2024
3b2c6ac
Fix comment
Dec 11, 2024
c05c5bd
Fix test
Dec 12, 2024
3ed9e17
Fix referenced services; we don't care about attached, we care that t…
Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix typos
  • Loading branch information
Kate Osborn committed Dec 11, 2024
commit ce0a9997de2f38d621c3bd144225122e37b17695
4 changes: 2 additions & 2 deletions internal/mode/static/state/graph/policies_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,7 +601,7 @@ func TestAttachPolicyToService(t *testing.T) {
name: "no attachment; gateway is invalid",
policy: &Policy{Source: &policiesfakes.FakePolicy{}},
svc: &ReferencedService{ParentGateways: []types.NamespacedName{winningGwNsName}},
gw: getGateway(false /*valid*/),
gw: getGateway(false /*invalid*/),
expAttached: false,
expAncestors: []PolicyAncestor{
{
Expand All @@ -625,7 +625,7 @@ func TestAttachPolicyToService(t *testing.T) {
t.Parallel()
g := NewWithT(t)

attachPolicyToService(test.policy, test.svc, test.gw, "ctrl")
attachPolicyToService(test.policy, test.svc, test.gw, "ctlr")
if test.expAttached {
g.Expect(test.svc.Policies).To(HaveLen(1))
} else {
Expand Down
6 changes: 3 additions & 3 deletions internal/mode/static/state/graph/service_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ func TestBuildReferencedServices(t *testing.T) {
exp: nil,
},
{
name: "route wil nil parent attachment status",
name: "route with nil parent attachment status",
l7Routes: map[RouteKey]*L7Route{
{NamespacedName: types.NamespacedName{Name: "nil-attachment-route"}}: nilAttachmentRoute,
},
Expand Down Expand Up @@ -395,6 +395,6 @@ func TestGetUniqueAttachedParentGateways(t *testing.T) {
{Namespace: "test2", Name: "attached-2"},
}

uniqueAtttachedRefs := getUniqueAttachedParentGateways(parentRefs)
g.Expect(uniqueAtttachedRefs).To(Equal(expectedNsNames))
uniqueAttachedRefs := getUniqueAttachedParentGateways(parentRefs)
g.Expect(uniqueAttachedRefs).To(Equal(expectedNsNames))
}