-
Notifications
You must be signed in to change notification settings - Fork 141
Added root path prefix in listings template #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for your contribution. I'd like to see a few changes before merging. First, the TODOs:
|
@dekobon, no problem. Sure, I can resolve TODOs. Just signal me if we are going with it in general. Does it suit an architecture, etc? |
Yes! This would be a good feature. |
Hi Elijah @dekobon, Does it look good for you? Could you merge PR? |
Excuse my lateness in addressing this PR. I tried to test out the PR, and I saw the following behavior. I see the following after enabling
I want to make sure that my understanding of the behavior is correct. I did not understand the behavior well based on the text in the readme. To confirm, this change modifies the paths presented by the index page, but does not change the actual paths served. Is that correct? |
Yes, you're absolutely right. I make requests through another proxy (in my case via HAProxy), which removes the same prefix from request path: I tried to make it in nginx-s3-gateway, but with no luck. |
I've made some changes to your PR and pushed it as a branch here: https://github.com/dekobon/nginx-s3-gateway/tree/dir-list-prefix In particular, I removed the templating done on the includes directory and instead used an xlst parameter. Please take a look at the above branch, test with your configuration and let me know the results. If it works for you, then I'd like to merge it. |
Hi. |
Hello.
I list my S3 bucket under some prefix. Currently nginx-s3-gateway doesn't allow it. I can (and I do) strip prefix in HAProxy, but get links without prefix in listing. See diagram below:
So, this PR prefixes links in directory listing with some predefined value. If it looks good, then I'll add variable into other containers and documentation.