Skip to content

Build multi-architecture images #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Jan 12, 2024
Merged

Build multi-architecture images #197

Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
5e851b4
trial staged build with github actions tooling
4141done Jan 9, 2024
c9b9a33
fix some yaml issues
4141done Jan 9, 2024
5f531ed
debug image state after loading base image in unprivileged build
4141done Jan 9, 2024
0d84f4f
adjust debug prints
4141done Jan 9, 2024
391f08d
move to a registry strategy to share base images due to buildx
4141done Jan 9, 2024
9944209
attempt a different build strategy to share base image
4141done Jan 10, 2024
4cc8a93
try building the base image, pushing, and saving
4141done Jan 10, 2024
6d1b798
wait for build to run before we start testing
4141done Jan 10, 2024
d0b303e
fix file path for oss image upload
4141done Jan 10, 2024
205fc95
add all tests
4141done Jan 10, 2024
e086211
correct image name in later tests
4141done Jan 10, 2024
1e32e13
add platforms to all build config
4141done Jan 10, 2024
4a022b2
redo build for base image, try the oci exporter
4141done Jan 10, 2024
793640f
simplify to just build for test initial stages
4141done Jan 10, 2024
c296ad5
add unprivileged
4141done Jan 10, 2024
c5aa0c0
add push job
4141done Jan 11, 2024
d79d4bd
fix bad comments
4141done Jan 11, 2024
fc657e7
fix missing date
4141done Jan 11, 2024
62813ca
get interpolation right in docker tag
4141done Jan 11, 2024
2569856
try moving to github.repository
4141done Jan 11, 2024
452d23b
clean up test script
4141done Jan 11, 2024
15fb908
remove syntax error
4141done Jan 11, 2024
fc4dd27
remove branch restrictions on test jobs. They should run always
4141done Jan 11, 2024
590c3e4
ensure runner version, set explicit artifact retention period
4141done Jan 12, 2024
8182945
fix temp dir
4141done Jan 12, 2024
fa22c86
try using the runner temp for file upload and download
4141done Jan 12, 2024
bb364c0
use the temp variable all the places
4141done Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ensure runner version, set explicit artifact retention period
  • Loading branch information
@4141done
4141done committed Jan 12, 2024
commit 590c3e46a2c62b1d647eaa4a4ba49f1d5015d711
22 changes: 14 additions & 8 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ env:

jobs:
build-oss-for-test:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v4
- name: Set up Docker Buildx
Expand All @@ -47,10 +47,12 @@ jobs:
uses: actions/upload-artifact@v3
with:
name: oss
path: /tmp/oss.tar
path: $TMPDIR/oss.tar
retention-days: 1
if-no-files-found: error

test-oss:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
needs: build-oss-for-test
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -83,7 +85,7 @@ jobs:
run: ./test.sh --type oss

build-latest-njs-for-test:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
needs: test-oss
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -116,9 +118,11 @@ jobs:
with:
name: latest-njs
path: /tmp/latest-njs.tar
retention-days: 1
if-no-files-found: error

test-latest-njs:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
needs: build-latest-njs-for-test
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -151,7 +155,7 @@ jobs:
run: ./test.sh --latest-njs --type oss

build-unprivileged-for-test:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
needs: test-oss
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -184,9 +188,11 @@ jobs:
with:
name: unprivileged
path: /tmp/unprivileged.tar
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refresh my memory if the uploaded artifacts eventually get cleaned up. I have a vague memory that they do.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a default setting for the repo which I believe is 30 days. However based on this comment I'm going to update the retention explicitly since so it's obvious from the script.

retention-days: 1 One day is the minimum which is really too long for this but should serve us fine.

Also worth noting that artifacts are only accessible from the workflow in which they were created so there's no chance of us pulling an old artifact which I was worried about initially.

retention-days: 1
if-no-files-found: error

test-unprivileged:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
needs: build-unprivileged-for-test
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -220,7 +226,7 @@ jobs:

# After the tests are done, build multiarch and push to both github packages and dockerhub if we are on master/main
tag-and-push:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
needs: [test-oss, test-latest-njs, test-unprivileged]

if: |
Expand Down