-
Notifications
You must be signed in to change notification settings - Fork 141
chore: update community files and workflows for org migration #387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a few suggestions, mostly style related. Generally speaking, looks like we have slightly different default editor options which leads to some incongruences between our setups:
- There are no blank lines at the end of files
- Markdown gets automatically split amongst multiple lines
It would be great to get those adjusted to the standard format across the other community OSS repos.
In so far as other changes:
- For consistency purposes, can we also rename
f5-cla.yml
tof5_cla.yml
andossf-scorecard.yml
toossf_scorecard.yml
? - Can you add a badge linking to the community forum and the license to the README (https://github.com/nginx/template-repository/blob/main/README.md?plain=1#L4-L5)? The copyright needs updating too 😄
- The PR template CLA link also needs to be updated
Co-authored-by: Alessandro Fael Garcia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found some more minor style changes that would be nice to have 🙃
Co-authored-by: Alessandro Fael Garcia <[email protected]>
Co-authored-by: Alessandro Fael Garcia <[email protected]>
Co-authored-by: Alessandro Fael Garcia <[email protected]>
Co-authored-by: Alessandro Fael Garcia <[email protected]>
Co-authored-by: Alessandro Fael Garcia <[email protected]>
Co-authored-by: Alessandro Fael Garcia <[email protected]>
Co-authored-by: Alessandro Fael Garcia <[email protected]>
Co-authored-by: Alessandro Fael Garcia <[email protected]>
Co-authored-by: Alessandro Fael Garcia <[email protected]>
Co-authored-by: Alessandro Fael Garcia <[email protected]>
Proposed changes
Closes #386
Checklist
Before creating a pull request (PR), run through this checklist and mark each as complete:
README.md
).