Skip to content

chore: update community files and workflows for org migration #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Apr 2, 2025

Conversation

TasoOneAsia
Copy link
Member

Proposed changes

Closes #386

Checklist

Before creating a pull request (PR), run through this checklist and mark each as complete:

@TasoOneAsia TasoOneAsia marked this pull request as ready for review March 28, 2025 16:35
@TasoOneAsia TasoOneAsia requested a review from alessfg March 28, 2025 16:43
Copy link
Member

@alessfg alessfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few suggestions, mostly style related. Generally speaking, looks like we have slightly different default editor options which leads to some incongruences between our setups:

  1. There are no blank lines at the end of files
  2. Markdown gets automatically split amongst multiple lines
    It would be great to get those adjusted to the standard format across the other community OSS repos.

In so far as other changes:

  1. For consistency purposes, can we also rename f5-cla.yml to f5_cla.yml and ossf-scorecard.yml to ossf_scorecard.yml?
  2. Can you add a badge linking to the community forum and the license to the README (https://github.com/nginx/template-repository/blob/main/README.md?plain=1#L4-L5)? The copyright needs updating too 😄
  3. The PR template CLA link also needs to be updated

@alessfg alessfg added the documentation Improvements or additions to documentation label Mar 31, 2025
Copy link
Member

@alessfg alessfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some more minor style changes that would be nice to have 🙃

@alessfg alessfg merged commit 93c0035 into nginx:main Apr 2, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch repo to NGINX org
2 participants