Skip to content

MNT: Move nisext imports from distutils to setuptools #1241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

penguinpee
Copy link
Contributor

  • TEST: Only use stable argsorts in PARREC tests
  • ENH: Warn on invalid MINC2 spacing declarations, treat as missing
  • Fix tests for Python 3.12

`distutils' have been removed from Python stdlib (nipy#1240).
@effigies effigies changed the base branch from master to maint/5.1.x July 17, 2023 15:10
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (134d469) 92.17% compared to head (65379bb) 92.17%.

Additional details and impacted files
@@             Coverage Diff              @@
##           maint/5.1.x    #1241   +/-   ##
============================================
  Coverage        92.17%   92.17%           
============================================
  Files               98       98           
  Lines            12376    12376           
  Branches          2544     2544           
============================================
  Hits             11407    11407           
  Misses             646      646           
  Partials           323      323           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@effigies
Copy link
Member

I'm okay with this, assuming you wouldn't prefer just to remove nisext from your package altogether.

@effigies effigies changed the title maint/5.1.x MNT: Move nisext imports from distutils to setuptools Jul 18, 2023
@effigies effigies merged commit a9c660c into nipy:maint/5.1.x Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants