Skip to content

output for DTI vectors changed (dcm2nii -> dcm2niix) #1463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2016

Conversation

cni-md
Copy link
Contributor

@cni-md cni-md commented May 2, 2016

New: Saving 65 DTI gradients. Please validate if you are conducting DTI
analyses.

see #1389

New: Saving 65 DTI gradients. Please validate if you are conducting DTI
analyses.
@coveralls
Copy link

coveralls commented May 2, 2016

Coverage Status

Coverage remained the same at 72.477% when pulling a73f39c on cni-md:master into b4d5088 on nipy:master.

@satra satra merged commit d337ff3 into nipy:master May 2, 2016
@@ -292,7 +292,7 @@ def _parse_stdout(self, stdout):
bvals.append(out_file + ".bval")
find_b = False
# next scan will have bvals/bvecs
elif 'DTI gradient directions' in line:
elif 'DTI gradients' in line:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would suggest changing to elif 'DTI gradient' in line: to make compatible with former output as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh,
that's nasty. I thought 'DTI gradient directions' was the old dcm2nii
syntax and copy&paste introduced this error, but now I realize that this
is "old" dcm2niiX output.

+1 for another elif statement

In nipype/interfaces/dcm2nii.py
#1463 (comment):

@@ -292,7 +292,7 @@ def _parse_stdout(self, stdout):
bvals.append(out_file + ".bval")
find_b = False
# next scan will have bvals/bvecs

  •            elif 'DTI gradient directions' in line:
    
  •            elif 'DTI gradients' in line:
    

would suggest changing to |elif 'DTI gradient' in line:| to make
compatible with former output as well

@satra
Copy link
Member

satra commented May 2, 2016

i fixed this in the upstream master. let's consider this a beta interface since @neurosclab is changing things depending on user needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants