Skip to content

Conversation

@ghisvail
Copy link
Collaborator

Add dependabot configuration watching updates to GitHub actions.

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.05 ⚠️

Comparison is base (a85bb14) 81.77% compared to head (7e9584f) 81.72%.

❗ Current head 7e9584f differs from pull request most recent head 755355f. Consider uploading reports for the commit 755355f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #633      +/-   ##
==========================================
- Coverage   81.77%   81.72%   -0.05%     
==========================================
  Files          20       20              
  Lines        4394     4394              
  Branches     1264        0    -1264     
==========================================
- Hits         3593     3591       -2     
- Misses        797      803       +6     
+ Partials        4        0       -4     
Flag Coverage Δ
unittests 81.72% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ghisvail
Copy link
Collaborator Author

I wonder how to fix codecov's spurious complaints 🤔

@effigies
Copy link
Contributor

Do we have some tests that only run on master, so PRs will always look like regressions?

@ghisvail ghisvail merged commit 99df677 into master Mar 27, 2023
@ghisvail ghisvail deleted the ci/dependabot branch March 27, 2023 13:54
@ghisvail
Copy link
Collaborator Author

Do we have some tests that only run on master, so PRs will always look like regressions?

I am not sure how to interpret what codecov is reporting here. I'll check with another PR.

It just sound weird to get coverage regression report on a PR adding a GHA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants