Skip to content

Conversation

@adi611
Copy link
Contributor

@adi611 adi611 commented Dec 30, 2023

Types of changes

  • New feature (non-breaking change which adds functionality)

Summary

add slurm dockerfile for reference

Checklist

  • I have added tests to cover my changes (if necessary)
  • I have updated documentation (if necessary)

@codecov
Copy link

codecov bot commented Dec 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@4f389cd). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #729   +/-   ##
=======================================
  Coverage        ?   83.52%           
=======================================
  Files           ?       23           
  Lines           ?     4990           
  Branches        ?     1429           
=======================================
  Hits            ?     4168           
  Misses          ?      814           
  Partials        ?        8           
Flag Coverage Δ
unittests 83.52% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tclose tclose added the to consider suggesting changes that require more discussion label Apr 2, 2025
@tclose
Copy link
Contributor

tclose commented Apr 2, 2025

Would be good to link this directly to the image used in the CI

@djarecka
Copy link
Collaborator

djarecka commented Apr 3, 2025

we have this image in CI, but we should probably update it

@tclose
Copy link
Contributor

tclose commented Apr 3, 2025

We could set it up as a package that gets automatically re-built at regular intervals

@github-project-automation github-project-automation bot moved this to In progress in Pydra Roadmap Apr 29, 2025
@tclose tclose moved this from In progress to Incomplete PRs in Pydra Roadmap Apr 29, 2025
@tclose tclose merged commit ce9b34c into nipype:main May 8, 2025
2 checks passed
@github-project-automation github-project-automation bot moved this from Bugs & Incomplete PRs to Done in Pydra Roadmap May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

to consider suggesting changes that require more discussion

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants