Skip to content

fetch, tag, and branch config values have surrounding tics #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EmperorMollusk opened this issue Mar 21, 2017 · 3 comments
Open

fetch, tag, and branch config values have surrounding tics #241

EmperorMollusk opened this issue Mar 21, 2017 · 3 comments

Comments

@EmperorMollusk
Copy link

Error seen on windows machines running 2.12.0.windows.1

git svn init command now has tics surrounding supplied trunk, tag, and branch locations i.e.

Running command: git svn init --prefix=svn/ --no-metadata --trunk='/path/to/trunk' --tags='/path/to/tags' --branches='/path/to/Branches' https://svn.repository.com/location

When this command is run the tics are added to the config file values i.e.

fetch = '/path/to/trunk':refs/remotes/svn/trunk

This makes the paths invalid and the fetch command never finds the path in the SVN repository.

@Skintkingle
Copy link

Skintkingle commented Nov 23, 2017

This absolutely is the problem on windows. I've confirmed this by manually editing out the ' around the --branches, --tags, --trunk generated paramters and it ran flawlessly without problems. This should be fixed. lets merge --stdlayout in!

@franbenz
Copy link

franbenz commented Apr 13, 2018

Here is an example of the editing @Skintkingle suggests in the comment above: https://stackoverflow.com/a/49349790/1608179
I don't know if the same would work on *nix, though.

@bernhof
Copy link

bernhof commented Apr 8, 2019

If tics are edited out, spaces in arguments aren't supported... While spaces are uncommon in branch names (and not supported in git anyway) the same issue applies to other arguments such as --exclude. In both cases, using double quotes (rather than no quotes) when running on Windows would be most appropriate.

Maybe consider having a separate switch that decides whether to use single or double quotes around arguments that are passed on to git svn? The naming could indicate that this is a Windows compatibility setting, like --windows-compat or whatever :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants