Skip to content
This repository was archived by the owner on Oct 7, 2022. It is now read-only.

Add --setup-requires option to install pip packages before building wheels. #82

Merged
merged 1 commit into from
Oct 10, 2016

Conversation

La0
Copy link
Contributor

@La0 La0 commented Oct 3, 2016

Needed to build scipy.
I tested it with this command in nix-shell:

TMPDIR=../tmp pypi2nix -v -V "3.5" -e scipy --pre-install "numpy" -E "openblas"

Pip does not complain anymore about numpy, but fails on a missing library (openblas), even if this lib. is set in the extra build inputs.


This change is Reviewable

@garbas
Copy link
Contributor

garbas commented Oct 3, 2016

i lost inline comments i wrote since FF crashed :(

anyway here is the shortlist how i see we need to move here:

  • setup requires should be handled within stage0 (pip.nix)
  • i already had a plan to separate pip wheel into pip install and pip wheel where pip wheel would only view sources from first pip install. this would also allow us to cache creation of wheels (should speed sequential runs by 50-90%)
  • i think option should be called --setup-requires since that is what setuptools calls it (i'm currently working splitting --editable options into --install-requires and --editable since some found it confusing that one option did 2 things
  • this new setup_requires option should be also part of buildInputs

@garbas
Copy link
Contributor

garbas commented Oct 4, 2016

i'm working on some "UI" changes which will change how options are called and i'm adding better description to --help with few examples how to use pypi2nix.

@La0 La0 changed the title Add --pre-install option to install pip packages before building wheels. Add --setup-requires option to install pip packages before building wheels. Oct 4, 2016
@garbas
Copy link
Contributor

garbas commented Oct 10, 2016

i'm merging this, but i need to do some fixes as well in afterward commits. tnx!

@garbas garbas merged commit e8ea2cd into nix-community:master Oct 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants