Skip to content

Remove duplicate function definitions #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

LinusU
Copy link
Member

@LinusU LinusU commented May 20, 2020

@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #37 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #37   +/-   ##
=======================================
  Coverage   86.95%   86.95%           
=======================================
  Files           1        1           
  Lines          69       69           
  Branches       13       13           
=======================================
  Hits           60       60           
  Misses          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fabfce...8057ac9. Read the comment docs.

@LinusU
Copy link
Member Author

LinusU commented May 20, 2020

Actually, I think that the reason that these were included in the first place was because they weren't present in upstream TypeScript at the time. This have been fixed now with: microsoft/TypeScript#36164

Since this is now fixed, what do we think about just doing:

/// <reference lib="dom"/>
export = Blob;

The drawback would be that we would remove [Symbol.toStringTag] and toString. But if we think that it's correct to have them on the Blob I think it would be better to submit patches upstream to add that instead, since the idea behind this package is to bring Blob cross platform.

@LinusU
Copy link
Member Author

LinusU commented May 21, 2020

Closing in favour of #38

@LinusU LinusU closed this May 21, 2020
@LinusU LinusU deleted the typings-update branch May 21, 2020 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant