Return empty a empty stream for zero sized blob #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 234 238 +4
Branches 38 40 +2
=========================================
+ Hits 234 238 +4
Continue to review full report at Codecov.
|
tinovyatkin
approved these changes
Apr 26, 2021
| ## next | ||
| - Fixed a bug where in BlobDataItem when the file was empty (#86) | ||
|
|
||
| ## v2.1.2 |
There was a problem hiding this comment.
I think, the changelog got out of sync with the actual changes. The changes mentioned in 2.1.1 were actually made in 2.1.2, so the next version would have what you currently mentioned in 2.1.2 and the actual 2.1.2 changes has to be taken from 2.1.1 section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createReadStream(x, {start:0, end:0})throws a out of bound error - so just return a empty stream instead