Skip to content

fix(changelog): allow for non-https protocols #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2025
Merged

fix(changelog): allow for non-https protocols #251

merged 1 commit into from
Apr 17, 2025

Conversation

avivkeller
Copy link
Member

Description

We should only get the file from the file system when we're certain the URL is referencing a file. This prevents misinterpreting other protocols—like http instead of https—as file paths.

Validation

See description

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I've covered new added functionality with unit tests if necessary.

@avivkeller avivkeller requested a review from a team as a code owner April 16, 2025 17:06
ovflowd
ovflowd approved these changes Apr 17, 2025
View reviewed changes
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avivkeller avivkeller merged commit 1e18d5f into main Apr 17, 2025
7 checks passed
@avivkeller avivkeller deleted the fix/changelog-http branch April 17, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ovflowd ovflowd ovflowd approved these changes

@flakey5 flakey5 flakey5 approved these changes

@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes

@bjohansebas bjohansebas bjohansebas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@avivkeller @ovflowd @flakey5 @AugustinMauroy @bjohansebas