You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Responding no to Do you wish to continue? results in Querying API for.... message
⠋ Querying API for job/node-test-pull-request/52248/ ✔ Aborted `git node land` session in /Users/yagiz/Developer/node/.ncu
⠦ Querying API for job/node-test-pull-request/52248/^C%
Full message
../node-core-utils/bin/git-node.js land 48349
Debugger listening on ws://127.0.0.1:9229/e7219178-9a7e-414b-a84e-ce8a226661bb
For help, see: https://nodejs.org/en/docs/inspector
✔ Done loading data for nodejs/node/pull/48349
----------------------------------- PR info ------------------------------------
Title src: introduce V8 fast api to `guessHandleType` (#48349)
Author Yagiz Nizipli <[email protected]> (@anonrig)
Branch anonrig:improve-guessHandleType -> nodejs:main
Labels lib / src, performance, needs-ci, commit-queue-failed, commit-queue-rebase
Commits 2
- src: return uint32 for `guessHandleType`
- src: add V8 fast api to `guessHandleType`
Committers 1
- Yagiz Nizipli <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/48349
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
--------------------------------------------------------------------------------
⚠ Commits were pushed since the last approving review:
⚠ - src: return uint32 for `guessHandleType`
⚠ - src: add V8 fast api to `guessHandleType`
ℹ This PR was created on Mon, 05 Jun 2023 16:41:28 GMT
✔ Approvals: 3
✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/48349#pullrequestreview-1465345051
✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/48349#pullrequestreview-1465728186
✔ - Minwoo Jung (@JungMinu): https://github.com/nodejs/node/pull/48349#pullrequestreview-1471073777
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2023-06-14T20:45:52Z: https://ci.nodejs.org/job/node-test-pull-request/52248/
⠋ Querying data for job/node-test-pull-request/52248/ ✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
? This PR is not ready to land, do you want to continue? No
⠋ Querying API for job/node-test-pull-request/52248/ ✔ Aborted `git node land` session in /Users/yagiz/Developer/node/.ncu
⠦ Querying API for job/node-test-pull-request/52248/^C%
The text was updated successfully, but these errors were encountered:
Responding
no
toDo you wish to continue?
results inQuerying API for....
messageFull message
The text was updated successfully, but these errors were encountered: