Skip to content

fix: properly terminate pr landing sessions #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Jun 14, 2023

This pull request properly terminates the CLI issue, but does not fix the unnecessary Querying for API... log.

Example output

? This PR is not ready to land, do you want to continue? No
⠋ Querying API for job/node-test-pull-request/52248/   ✔  Aborted `git node land` session in /Users/yagiz/Developer/node/.ncu

Reference: #707

@anonrig anonrig requested a review from aduh95 June 14, 2023 21:20
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6477632) 83.38% compared to head (f06d9e3) 83.38%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #708   +/-   ##
=======================================
  Coverage   83.38%   83.38%           
=======================================
  Files          37       37           
  Lines        4158     4158           
=======================================
  Hits         3467     3467           
  Misses        691      691           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love that, much better DX

@aduh95 aduh95 merged commit 015bf20 into nodejs:main Jun 14, 2023
@anonrig anonrig deleted the fix-pr-land branch June 14, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants