docs: update Jenkins profile access #668
Conversation
Codecov ReportBase: 83.41% // Head: 83.41% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #668 +/- ##
=======================================
Coverage 83.41% 83.41%
=======================================
Files 37 37
Lines 4136 4136
=======================================
Hits 3450 3450
Misses 686 686 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
VoltrexKeyva
force-pushed
the
jenkins-profile
branch
from
205cb15 to
a65ba1a
Compare
VoltrexKeyva
changed the title
README.md
Outdated
| `https://ci.nodejs.org/user/<your-github-username>/configure` (replace | ||
| \<your-github-username\> with your own GitHub username) |
There was a problem hiding this comment.
While we're at it, let's fix the indentation and the punctuation.
| `https://ci.nodejs.org/user/<your-github-username>/configure` (replace | |
| \<your-github-username\> with your own GitHub username) | |
| `https://ci.nodejs.org/user/<your-github-username>/configure` (replace | |
| \<your-github-username\> with your own GitHub username). |
There was a problem hiding this comment.
Done, though indented with 2 spaces instead of 3 to stay consistent with the other lines.
There was a problem hiding this comment.
It should be 3 though, according to https://spec.commonmark.org/0.30/#list-items
the continuation blocks must be indented at least to the column of the first character other than a space or tab after the list marker
(as the spec says, the above sentence is a simplification and is not always correct, but it is correct in this case)
I don't have a strong opinion wether we should fix the other occurrences before or after this PR, but I don't think it's correct to land this with only 2 spaces.
There was a problem hiding this comment.
I'll indent it with 3 spaces and open a new PR to fix the other occurrences.
VoltrexKeyva
force-pushed
the
jenkins-profile
branch
from
a65ba1a to
0d68b6d
Compare
The Node.js Jenkins server now only allows you to access your Jenkins profile with your GitHub username rather than your GitHub ID.
VoltrexKeyva
force-pushed
the
jenkins-profile
branch
from
0d68b6d to
a3f1760
Compare
|
@aduh95 can you merge this before I open the new PR? |
The Node.js Jenkins server now only allows you to access your Jenkins profile with your GitHub username rather than your GitHub ID.