Skip to content

chore(deps): do not use the deprecated Cheerio API #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Feb 26, 2023

Cheerio has deprecated the default export, instead we should be using the named ones.

@codecov
Copy link

codecov bot commented Feb 26, 2023

Codecov Report

Base: 83.41% // Head: 83.41% // No change to project coverage 👍

Coverage data is based on head (66b4d3a) compared to base (6926407).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #673   +/-   ##
=======================================
  Coverage   83.41%   83.41%           
=======================================
  Files          37       37           
  Lines        4136     4136           
=======================================
  Hits         3450     3450           
  Misses        686      686           
Impacted Files Coverage Δ
lib/links.js 91.86% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aduh95 aduh95 merged commit a2db757 into nodejs:main Feb 26, 2023
@aduh95 aduh95 deleted the cheerio-deprecation branch February 26, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants