Skip to content

feat(git-node): add git node vote #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 3, 2023
Merged

feat(git-node): add git node vote #704

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4b54646
feat(git-node): add `git node vote`
aduh95 Jun 14, 2023
ee1951d
switch to `node-core` scope
aduh95 Jun 28, 2023
5368c46
fix version
aduh95 Jun 28, 2023
c2e4af0
Merge branch 'main' into git-node-vote
aduh95 Jun 28, 2023
e22e7cb
add support for git env variables
aduh95 Jun 29, 2023
fd57926
Update components/git/vote.js
aduh95 Jun 30, 2023
992fb0a
Apply suggestions from code review + more
aduh95 Jun 30, 2023
a92209f
Apply suggestions from code review
aduh95 Jul 1, 2023
0a4d41e
Merge branch 'main' into git-node-vote
aduh95 Sep 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update components/git/vote.js 
Co-authored-by: Mohammed Keyvanzadeh <[email protected]>
  • Loading branch information
@aduh95 @VoltrexKeyva
aduh95 and VoltrexKeyva authored Jun 30, 2023
commit fd579261c21c5ca07971f39cb49c006468622324
6 changes: 3 additions & 3 deletions components/git/vote.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,11 @@ export function builder(yargs) {
describe: 'URL of the vote Pull Request'
})
.example('git node vote https://github.com/nodejs/TSC/pull/12344',
'Start an interactive session to cast ballot for https://github.com/nodejs/TSC/pull/12344. ')
'Start an interactive session to cast ballot for https://github.com/nodejs/TSC/pull/12344.')
.example('git node vote https://github.com/nodejs/TSC/pull/12344 --abstain',
'Cast an empty ballot for https://github.com/nodejs/TSC/pull/12344')
'Cast an empty ballot for https://github.com/nodejs/TSC/pull/12344.')
.example('git node vote https://github.com/nodejs/TSC/pull/12344 --decrypt-key-part',
'Uses gpg to decrypt a key part to close the vote happening on https://github.com/nodejs/TSC/pull/12344');
'Uses gpg to decrypt a key part to close the vote happening on https://github.com/nodejs/TSC/pull/12344.');
}

export function handler(argv) {
Expand Down