fs: add support for URL for fs.glob's cwd option
#58182
Open
+48
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
fs
aduh95
added
dont-land-on-v20.x
cjihrig
approved these changes
May 5, 2025
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58182 +/- ##
=======================================
Coverage 90.14% 90.14%
=======================================
Files 630 630
Lines 186784 186785 +1
Branches 36653 36654 +1
=======================================
+ Hits 168377 168379 +2
- Misses 11205 11210 +5
+ Partials 7202 7196 -6
🚀 New features to boost your workflow:
|
anonrig
reviewed
May 5, 2025
| @@ -268,7 +269,7 @@ class Glob { | |||
| constructor(pattern, options = kEmptyObject) { | |||
| validateObject(options, 'options'); | |||
| const { exclude, cwd, withFileTypes } = options; | |||
| this.#root = cwd ?? '.'; | |||
There was a problem hiding this comment.
Nit: These additions make optimizations extremely hard. We should avoid adding them.
There was a problem hiding this comment.
You're commenting on a deleted line, it's not very clear what you mean
There was a problem hiding this comment.
Adding a URL support to input field
aduh95
commented
May 5, 2025
LiviaMedeiros
approved these changes
May 6, 2025
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the sake of consistency, all the Node.js APIs that take a path also accept
URLinstances.