test: fix watch tests not including completion messages #58183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
dario-piotrowicz
added
the
fast-track
|
Fast-track has been requested by @dario-piotrowicz. Please 👍 to approve. |
dario-piotrowicz
commented
May 5, 2025
| ]); | ||
| }); | ||
|
|
||
| it('`--watch-path` ars without `=` used alongside `--watch` should not make it into the script', async () => { | ||
| it('`--watch-path` args without `=` used alongside `--watch` should not make it into the script', async () => { |
There was a problem hiding this comment.
unrelated typo fix 🙂
anonrig
approved these changes
May 5, 2025
dario-piotrowicz
changed the title
dario-piotrowicz
force-pushed
the
dario/fix-broken-watch-tests
branch
from
a919cb9 to
7c8ec53
Compare
LiviaMedeiros
approved these changes
May 5, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58183 +/- ##
=======================================
Coverage 90.15% 90.15%
=======================================
Files 630 630
Lines 186756 186756
Branches 36648 36649 +1
=======================================
+ Hits 168362 168365 +3
+ Misses 11193 11190 -3
Partials 7201 7201 🚀 New features to boost your workflow:
|
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
LiviaMedeiros
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 6102159 |
|
Thanks a lot @LiviaMedeiros for helping getting this PR landed 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier I merged #57936 which was out of sync with main so it didn't include the watch completion messages introduced in #57926
This causes the watch tests to be failing on main, this PR is addressing this issue
I'm really sorry for the inconvenience 🙇