Skip to content

[v22.x backport]deps: V8: cherry-pick 6b1b9bca2a8 #59663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[v22.x backport]deps: V8: cherry-pick 6b1b9bca2a8 #59663

wants to merge 1 commit into from

Conversation

@Xiao-Tao
Copy link
Contributor

@Xiao-Tao Xiao-Tao commented Aug 28, 2025

Backports #59283 to v22.x.

CC: @marco-ippolito @aduh95

@Xiao-Tao
deps: V8: cherry-pick 6b1b9bca2a8
1ad45f3 
Origin commit message:

    [loong64][codegen] Avoid memory access under stack pointer

    According to LoongArch ABI doc chapter 8.2:
      "Procedures must not assume the persistence on-stack data of which
       the addresses lie below the stack pointer."

    Change-Id: I92735e052227495ac9884c4290b57eaffbf905e1
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6786372
    Auto-Submit: Zhao Jiazhong <[email protected]>
    Reviewed-by: Matthias Liedtke <[email protected]>
    Commit-Queue: Matthias Liedtke <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#101634}

Refs: v8/v8@6b1b9bc
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 28, 2025

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. v8 engine Issues and PRs related to the V8 dependency. labels Aug 28, 2025
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 3, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 3, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 3, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/69036/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 3, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6728/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 3, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6728/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 3, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6728/

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 17, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 17, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 17, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/69269/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 17, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6761/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 17, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6761/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 17, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6761/

richardlau pushed a commit that referenced this pull request Sep 19, 2025
@Xiao-Tao @richardlau
deps: V8: cherry-pick 6b1b9bca2a8
2986eca 
Origin commit message:

    [loong64][codegen] Avoid memory access under stack pointer

    According to LoongArch ABI doc chapter 8.2:
      "Procedures must not assume the persistence on-stack data of which
       the addresses lie below the stack pointer."

    Change-Id: I92735e052227495ac9884c4290b57eaffbf905e1
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6786372
    Auto-Submit: Zhao Jiazhong <[email protected]>
    Reviewed-by: Matthias Liedtke <[email protected]>
    Commit-Queue: Matthias Liedtke <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#101634}

Refs: v8/v8@6b1b9bc
Backport-PR-URL: #59663
PR-URL: #59283
Reviewed-By: Marco Ippolito <[email protected]>
@richardlau
Copy link
Member

richardlau commented Sep 19, 2025

Landed in 2986eca

@richardlau richardlau closed this Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Xiao-Tao @nodejs-github-bot @richardlau @marco-ippolito