Skip to content

[v22.x] esm: add experimental support for addon modules #59961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[v22.x] esm: add experimental support for addon modules #59961

wants to merge 1 commit into from

Conversation

@legendecas
Copy link
Member

@legendecas legendecas commented Sep 21, 2025

PR-URL: #55844
Fixes: #40541
Fixes: #55821
Reviewed-By: Guy Bedford [email protected]
Reviewed-By: Geoffrey Booth [email protected]
Reviewed-By: Joyee Cheung [email protected]
Reviewed-By: Jacob Smith [email protected]
Reviewed-By: Antoine du Hamel [email protected]

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 21, 2025

Review requested:

  • @nodejs/config
  • @nodejs/gyp
  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Sep 21, 2025
@richardlau
Copy link
Member

richardlau commented Sep 21, 2025

This has a linter failure:
https://github.com/nodejs/node/actions/runs/17895087034/job/50880646671?pr=59961#step:5:19

 Running JS linter...

/home/runner/work/node/node/test/addons/esm/test-esm.mjs
  7:1  error  Unused eslint-disable directive (no problems were reported from 'node-core/require-common-first')

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

make: *** [Makefile:1441: lint-js] Error 1

@legendecas
esm: add experimental support for addon modules
ad649aa 
PR-URL: nodejs#55844
Fixes: nodejs#40541
Fixes: nodejs#55821
Reviewed-By: Guy Bedford <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 21, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/69315/

richardlau pushed a commit that referenced this pull request Sep 22, 2025
@legendecas @richardlau
esm: add experimental support for addon modules
d302cb3 
PR-URL: #55844
Backport-PR-URL: #59961
Fixes: #40541
Fixes: #55821
Reviewed-By: Guy Bedford <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@richardlau
Copy link
Member

richardlau commented Sep 22, 2025

Landed in d302cb3

@richardlau richardlau closed this Sep 22, 2025
@legendecas legendecas deleted the backport-55844-to-22 branch September 23, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@legendecas @nodejs-github-bot @richardlau