process: fix wrong asyncContext under unhandled-rejections=strict #60103
+30
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60103 +/- ##
==========================================
- Coverage 88.45% 88.43% -0.03%
==========================================
Files 703 703
Lines 207546 207794 +248
Branches 40011 40018 +7
==========================================
+ Hits 183591 183766 +175
- Misses 15949 16008 +59
- Partials 8006 8020 +14
🚀 New features to boost your workflow:
|
addaleax
approved these changes
Oct 2, 2025
addaleax
added
async_hooks
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
cjihrig
approved these changes
Oct 2, 2025
gurgunday
approved these changes
Oct 2, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Flarna
approved these changes
Oct 3, 2025
Flarna
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 60f1a5d |
targos
pushed a commit
that referenced
this pull request
Oct 6, 2025
Fixes: #60034 PR-URL: #60103 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Oct 22, 2025
Fixes: #60034 PR-URL: #60103 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
|
Thanks a lot for this fix. Would it be possible to apply it in Node 20.x as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #60034
When I looked at the crash point in the issue, I found that asyncId was undefined.
https://github.com/nodejs/node/blob/main/src/api/callback.cc#L185
I suspect that the code may have been mistakenly changed in this PR.
https://github.com/nodejs/node/pull/52108/files#diff-04f0a68c4bc76396de863bbe0982c85d70a5b71432bdc26bc503e3ac317c6f82L263