CI: Static export locale #7409
Merged
CI: Static export locale #7409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I didn't get why we need that ? |
lazy consensus from a thread at https://openjs-foundation.slack.com/archives/CVAMEJ4UV/p1735409553256659 |
There was a problem hiding this comment.
I just checked, cause I want to make sure the crowdin build preview in vercel triggers off of the PR, not the push.
The logic uses VERCEL_GIT_COMMIT_REF which is the branch name, so we should be good
ovflowd
reviewed
Jan 16, 2025
ovflowd
reviewed
Jan 16, 2025
ovflowd
reviewed
Jan 16, 2025
ovflowd
reviewed
Jan 16, 2025
I checked the pages where |
ovflowd
approved these changes
Jan 18, 2025
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
Unit Test Coverage Report
Unit Test Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this PR we aim to only export the default language statically instead of statically exporting all pages based on environment variables
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.