Skip to content

fix(learn): current sendMail typo #7940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2025

Conversation

TheUncertaintim
Copy link
Contributor

Description

This PR fixed a few typos in the code snippets provided in the Learn/Asynchronous Work section.

Validation

Typo

The function named sendMail() is now mentioned correctly in the comment (instead of sendEmail())

image

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@TheUncertaintim TheUncertaintim requested a review from a team as a code owner July 3, 2025 13:02
Copy link

vercel bot commented Jul 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jul 3, 2025 1:04pm

@avivkeller avivkeller changed the title docs: Update typos in example snippets fix(learn): current sendMail typo Jul 3, 2025
@avivkeller avivkeller added fast-track Fast Tracking PRs github_actions:pull-request Trigger Pull Request Checks labels Jul 3, 2025
@avivkeller
Copy link
Member

Requesting fast track

@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jul 3, 2025
Copy link
Contributor

github-actions bot commented Jul 3, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 96 🟢 100 🟠 82 🔗
/en/about/previous-releases 🟢 100 🟢 96 🟢 100 🟠 83 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

Copy link

codecov bot commented Jul 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@a7ba5fc). Learn more about missing BASE report.
Report is 7 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7940   +/-   ##
=======================================
  Coverage        ?   75.40%           
=======================================
  Files           ?       96           
  Lines           ?     8354           
  Branches        ?      219           
=======================================
  Hits            ?     6299           
  Misses          ?     2053           
  Partials        ?        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avivkeller avivkeller added this pull request to the merge queue Jul 3, 2025
Merged via the queue into nodejs:main with commit 0e72af7 Jul 3, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track Fast Tracking PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants