Skip to content

chore: pipe the webServer output for cloudflare playwright runs #7951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dario-piotrowicz
Copy link
Member

@dario-piotrowicz dario-piotrowicz commented Jul 4, 2025

Description

As I've mentioned here: #7947 (comment) I'm updating the playwright config to expose the stdout for Cloudflare runs.

This can be a bit noisy but I think the extra info that we can get out of the stdout in case of issues will definitely make it worth it (since as you can see from this run: Cloudflare Playwright CI run we are not getting much info when actual issues occur during the build process).

Validation

Validated in this PR, I've purposely broken the open-next preview: 8938872 and then run the playwright e2es:

As you can see with the output with stdout piping the error is visible in the CI run while without piping it is not.

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Copy link

vercel bot commented Jul 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jul 4, 2025 5:21pm

Copy link

codecov bot commented Jul 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.37%. Comparing base (4ebead0) to head (8a05a75).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7951      +/-   ##
==========================================
- Coverage   75.42%   75.37%   -0.05%     
==========================================
  Files          96       96              
  Lines        8354     8354              
  Branches      219      220       +1     
==========================================
- Hits         6301     6297       -4     
- Misses       2051     2055       +4     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dario-piotrowicz dario-piotrowicz force-pushed the dario/more-open-next-ci-e2e-logs branch from 8a05a75 to 6b107d8 Compare July 4, 2025 17:24
@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review July 4, 2025 17:24
@Copilot Copilot AI review requested due to automatic review settings July 4, 2025 17:24
@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner July 4, 2025 17:24
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

A succinct update to enable Playwright’s webServer stdout piping during Cloudflare preview runs for better CI diagnostics.

  • Adds stdout: 'pipe' to the Playwright webServer config when PLAYWRIGHT_RUN_CLOUDFLARE_PREVIEW is set
  • Aims to surface server logs in CI for easier debugging of build and test failures

@avivkeller avivkeller enabled auto-merge July 7, 2025 17:49
@avivkeller avivkeller added the github_actions:pull-request Trigger Pull Request Checks label Jul 7, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jul 7, 2025
@avivkeller avivkeller added this pull request to the merge queue Jul 7, 2025
Merged via the queue into nodejs:main with commit 6eace68 Jul 7, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants