-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
chore: pipe the webServer output for cloudflare playwright runs #7951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: pipe the webServer output for cloudflare playwright runs #7951
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7951 +/- ##
==========================================
- Coverage 75.42% 75.37% -0.05%
==========================================
Files 96 96
Lines 8354 8354
Branches 219 220 +1
==========================================
- Hits 6301 6297 -4
- Misses 2051 2055 +4
Partials 2 2 ☔ View full report in Codecov by Sentry. |
8a05a75
to
6b107d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
A succinct update to enable Playwright’s webServer stdout piping during Cloudflare preview runs for better CI diagnostics.
- Adds
stdout: 'pipe'
to the Playwright webServer config whenPLAYWRIGHT_RUN_CLOUDFLARE_PREVIEW
is set - Aims to surface server logs in CI for easier debugging of build and test failures
Description
As I've mentioned here: #7947 (comment) I'm updating the playwright config to expose the stdout for Cloudflare runs.
This can be a bit noisy but I think the extra info that we can get out of the stdout in case of issues will definitely make it worth it (since as you can see from this run: Cloudflare Playwright CI run we are not getting much info when actual issues occur during the build process).
Validation
Validated in this PR, I've purposely broken the open-next preview: 8938872 and then run the playwright e2es:
As you can see with the output with stdout piping the error is visible in the CI run while without piping it is not.
Related Issues
Check List
pnpm format
to ensure the code follows the style guide.pnpm test
to check if all tests are passing.pnpm build
to check if the website builds without errors.