Skip to content

Isaacs/fix tests and fail properly #1719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Isaacs/fix tests and fail properly #1719

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9f200ab
Remove reliance on the _exit pseudo-config in error handler
isaacs Aug 24, 2020
79f851c
Detect CI properly in flatOptions generation
isaacs Aug 24, 2020
86e243e
test: streamline snapshot on config test
isaacs Aug 24, 2020
aad5008
test: add workaround for node 10's broken promises
isaacs Aug 24, 2020
b62e120
test: make cache dir cross-platform consistent in config test
isaacs Aug 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: add workaround for node 10's broken promises
  • Loading branch information
@isaacs
isaacs committed Aug 24, 2020
commit aad50089dc5221294c5128e4d3d0f146b9279d2a
3 changes: 3 additions & 0 deletions test/lib/npm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,9 @@ t.test('npm.load', t => {
])
t.same(consoleLogs, [['@foo']])
})

// need this here or node 10 will improperly end the promise ahead of time
await new Promise((res) => setTimeout(res))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is crazy hacky, would love to learn about the edge case going on here

})

t.end()
Expand Down