fix(ls): correctly show deduped dependencies #8217
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix
npm ls
outputProblem:
npm ls dep-name
ifdep-name
is a child of some deduped parent then whole tree would be shown till that parent but logicallydep-name
is still the child/grand-child of that.dep1
is ancestor ofdep2
which again depends ondep1
creating a cycle when explored, also the algorithm used is BFS so it's hard to detect cycle.Solution:
Progress:
Test output
`npm ls child` - before and after
Before
After