-
Notifications
You must be signed in to change notification settings - Fork 671
[nrf fromtree] boards: nordic: Enable nfct on the supporting boards #2873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Enable NFCT device in dts of the boards that have NFC connector. Signed-off-by: Radosław Koppel <[email protected]> (cherry picked from commit e37b68b)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I doubt this is a proper way of working with the boards. Enabling nodes enables code which have impact on binary size.
@dchat-nordic , can you confirm that on boards where the node was enabled there was no impact on the size of the resulting binaries for apps/samples that do not use NFC?
Please check |
Currently, no SW component depends on the nfct node status (through dts scripts). The only exception is a Kconfig option which enables NFC in some BlueBagel application or sample (I don't remember which). Eventually, subsys/nfc/platform.c and related code should depend on this node, but this is not aligned yet. Even when the alignment is there, the binary size I believe will ultimately depend on Kconfig option chosen e.g. if CONFIG_NFC_PLATFORM. |
@pdunaj I checked on nrf54l05 for hids_keyboard and there is no change in binary size. |
Enable NFCT device in dts of the boards that have
NFC connector.
This is part of NCSDK-32456, since it didn't make it before upmerge.
(cherry picked from commit e37b68b)