Skip to content

[nrf fromtree] boards: nordic: Enable nfct on the supporting boards #2873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025

Conversation

dchat-nordic
Copy link
Contributor

Enable NFCT device in dts of the boards that have
NFC connector.

This is part of NCSDK-32456, since it didn't make it before upmerge.

(cherry picked from commit e37b68b)

Enable NFCT device in dts of the boards that have
NFC connector.

Signed-off-by: Radosław Koppel <[email protected]>
(cherry picked from commit e37b68b)
Copy link

Copy link
Contributor

@pdunaj pdunaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt this is a proper way of working with the boards. Enabling nodes enables code which have impact on binary size.
@dchat-nordic , can you confirm that on boards where the node was enabled there was no impact on the size of the resulting binaries for apps/samples that do not use NFC?

@pdunaj
Copy link
Contributor

pdunaj commented May 16, 2025

Please check boards/nordic/nrf54l15dk/nrf54l_05_10_15_cpuapp_common.dtsi impact on nrf54l05 - you can look at some hid sample. If it does not negatively impact the binary size then the change is ok.

@grochu
Copy link
Contributor

grochu commented May 16, 2025

I doubt this is a proper way of working with the boards. Enabling nodes enables code which have impact on binary size. @dchat-nordic , can you confirm that on boards where the node was enabled there was no impact on the size of the resulting binaries for apps/samples that do not use NFC?

Currently, no SW component depends on the nfct node status (through dts scripts). The only exception is a Kconfig option which enables NFC in some BlueBagel application or sample (I don't remember which). Eventually, subsys/nfc/platform.c and related code should depend on this node, but this is not aligned yet. Even when the alignment is there, the binary size I believe will ultimately depend on Kconfig option chosen e.g. if CONFIG_NFC_PLATFORM.

@dchat-nordic
Copy link
Contributor Author

@pdunaj Currently no code or binaries are attached with HAS_NRF_NFCT or similar config resulting from those changes. As @grochu said the NFC libraries and code is selected by Kconfigs CONFIG_NFC_T2T_NRFXLIB CONFIG_NFC_T4T_NRFXLIB and CONFIG_NFC_PLATFORM which are n by default AFAIK.

@dchat-nordic
Copy link
Contributor Author

@pdunaj I checked on nrf54l05 for hids_keyboard and there is no change in binary size.

@dchat-nordic dchat-nordic requested a review from pdunaj May 22, 2025 12:48
@rlubos rlubos merged commit 5b20260 into nrfconnect:main May 26, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants