[nrf fromtree] drivers: spi: spi_nrfx_spi: remove multithreading dependency #2907
+95
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordic-mik7
force-pushed
the
dev/spi_single_thread
branch
from
f0b527a to
57435f3
Compare
nordic-mik7
force-pushed
the
dev/spi_single_thread
branch
from
57435f3 to
bc69e4b
Compare
nordic-mik7
changed the title
nordic-mik7
force-pushed
the
dev/spi_single_thread
branch
3 times, most recently
from
8304257 to
9e44861
Compare
nordic-mik7
force-pushed
the
dev/spi_single_thread
branch
2 times, most recently
from
2405a6c to
124e29f
Compare
This dependency was always there but not explicitly defined. By adding the explicit dependency it becomes more obvious what is wrong when SPI is enabled but GPIO disabled. This was found when building `samples/bluetooth/peripheral` for `nrf54l15dk/nrf54l15/cpuapp` with `CONFIG_GPIO=n`. Before we got: - A linker error in `spi_nrfx_common.c` failing to reference some nrfx_gpiote APIs. - A linker error in `spi_nrfx_spim.c` failing to reference the GPIO dts entry. Now we will get a warning of that GPIO is not enabled With this it becomes more obvious that SPI driver is enabled by default because of the external flash mounted on the DK. Signed-off-by: Rubin Gerritsen <[email protected]> (cherry picked from commit 577a004)
nordic-mik7
force-pushed
the
dev/spi_single_thread
branch
from
124e29f to
8c97a70
Compare
|
@anangl @ahasztag Please review and approve if you find time; upstream PR already reviewed and pending merge: |
|
Please change the second commit to fromtree. |
ahasztag
reviewed
Jun 2, 2025
| const uint32_t tms = k_uptime_get_32(); | ||
|
|
||
| while (!atomic_get(&ctx->ready) && (k_uptime_get_32() - tms < timeout_ms)) { | ||
| k_busy_wait(1); |
There was a problem hiding this comment.
Why k_busy_wait(1) is needed here? I'd rather say this should be an empty while loop, this does only add unnecessary code
There was a problem hiding this comment.
It is unnecessary indeed... Already merged to upstream though
ahasztag
approved these changes
Jun 2, 2025
…endency Replace semaphores with proper atomic flags when used without multithreading enabled. Related: NCSDK-33699 Signed-off-by: Michal Kozikowski <[email protected]> (cherry picked from commit df65918)
nordic-mik7
force-pushed
the
dev/spi_single_thread
branch
from
8c97a70 to
5350c72
Compare
nordic-mik7
changed the title
anangl
approved these changes
Jun 2, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace semaphores with proper atomic flags when used without multithreading enabled.
Related: NCSDK-33699