[nrf fromtree] tests: boards: nrf: i2s: i2s_divider: Confirm CLK value #2918
+306
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordic-segl
force-pushed
the
NRFX-7607_I2S-find-correct-clock
branch
from
e62c061 to
2ff20f7
Compare
|
Works in CI: |
nordic-segl
force-pushed
the
NRFX-7607_I2S-find-correct-clock
branch
from
2ff20f7 to
33706db
Compare
nordic-piks
approved these changes
May 28, 2025
bjarki-andreasen
approved these changes
May 28, 2025
nordic-segl
force-pushed
the
NRFX-7607_I2S-find-correct-clock
branch
from
33706db to
f97b619
Compare
nordic-segl
changed the title
|
Changes in upstream were requested. PR was significantly reworked. |
nordic-segl
force-pushed
the
NRFX-7607_I2S-find-correct-clock
branch
2 times, most recently
from
784f4b6 to
981d99b
Compare
|
Works in CI: |
nordic-bami
approved these changes
May 30, 2025
nordic-pikr
approved these changes
May 30, 2025
Fix typo in the Kconfig file. Change 'per socond' to 'per second'. Signed-off-by: Sebastian Głąb <[email protected]> (cherry picked from commit b991632)
…der value Frame rate selected by the user may not be obtained due to PCLK frequency and finite number of clock divider values. In such case, driver shall select divider that results in frame clock rate closest to the requested value. There was a bug that was discarding perfect match divider. Add test which confirms correct clock divider selection. Signed-off-by: Sebastian Głąb <[email protected]> (cherry picked from commit af43487)
nordic-segl
force-pushed
the
NRFX-7607_I2S-find-correct-clock
branch
from
981d99b to
7a37e79
Compare
|
nordic-segl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test which confirms correct clock divider selection.
Frame rate selected by the user may not be obtained due to PCLK clock value and finite number of clock divider value.
In such case, driver shall select divider that results in frame clock rate closest to the requested value.
There was a bug that was discarding perfect match divider.
Upstream PR #: TBD