[nrf fromlist] drivers: nrf_ironside dvfs service #2921
Conversation
lstnl
force-pushed
the
move_DVFS_to_secdom
branch
3 times, most recently
from
e46cd01 to
4bc4cf5
Compare
Added handling of new IRONside DVFS service. NRFS DVFS is now not enabled by default. Upstream PR #: 90755 Signed-off-by: Łukasz Stępnicki <[email protected]>
lstnl
force-pushed
the
move_DVFS_to_secdom
branch
from
4bc4cf5 to
d7a066a
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR implements the IRONside DVFS service, adding new handling for DVFS operating point changes while ensuring it is not enabled by default.
- Removed default enabling of NRFS DVFS service in nRF54H Kconfig
- Added conditional includes and source additions for DVFS support in hal_nordic and IRONside driver CMakeLists.txt
- Introduced new header and implementation files for IRONside DVFS service
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| soc/nordic/nrf54h/Kconfig | Removed selection of NRFS_HAS_DVFS_SERVICE to disable DVFS by default |
| modules/hal_nordic/nrfs/CMakeLists.txt | Updated include and source directives to conditionally incorporate DVFS service support |
| include/zephyr/drivers/firmware/nrf_ironside/ironside_dvfs.h | Added header for new IRONside DVFS service APIs |
| drivers/firmware/nrf_ironside/ironside_dvfs.c | Added implementation of DVFS oppoint change functionality and configuration routines |
| drivers/firmware/nrf_ironside/Kconfig | Added new configuration option for enabling the IRONside DVFS service |
| drivers/firmware/nrf_ironside/CMakeLists.txt | Included new DVFS implementation source file conditionally based on configuration |
| SystemCoreClock = dvfs_hsfll_data[oppoint_freq].max_hsfll_freq; | ||
| } | ||
|
|
||
| /* Perform scaling finnish procedure. */ |
There was a problem hiding this comment.
Typo detected: change 'finnish' to 'finish' in the comment.
| /* Perform scaling finnish procedure. */ | |
| /* Perform scaling finish procedure. */ |
Copilot uses AI. Check for mistakes.
| /** | ||
| * @brief Configure hsfll depending on selected oppoint | ||
| * | ||
| * @param enum oppoint target operation point |
There was a problem hiding this comment.
[nitpick] Consider updating the parameter documentation to explicitly specify the type as 'enum ironside_dvfs_oppoint' and include the parameter name for clarity.
Copilot uses AI. Check for mistakes.
|
Added handling of new IRONside DVFS service.
NRFS DVFS is now not enabled by default.
Upstream PR #: 90755