Skip to content

Several improvements of functionality and UI usability #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 16 commits into from
Closed

Several improvements of functionality and UI usability #41

wants to merge 16 commits into from

Conversation

cryptogopher
Copy link

Following is a list of major changes:

  • added support for modified month ocurrences (e.g. "on 10th day before month end", "on second Tuesday of month"),
  • removed "show" recurrence view. In my opinion it was duplicating what has already been shown in "issue" view and added unnecessary one more click to get to "edit" view.
  • modified task generation process (invoked through cron) to create next recurrence as soon as previous recurrence day is reached. This way next task recurrence is known in advance (not 1 day before its due date as before). It is important to allow planning issue execution efficiently in real life.
  • partly changed UI design to better match native Redmine look and allow more efficient usage of plugin,
  • other minor changes

cryptogopher added 16 commits May 13, 2014 19:54
@cryptogopher
Preliminary support for month recurrences with modifiers
9ddc057 
Also improved drop-down list in "Edit" form to read state
by value rather than localized text.
@cryptogopher
Default values for new recurrences + minor fixes.
c99824b
@cryptogopher
Adding column for month recurrence modifiers.
e51058e
@cryptogopher
More informative/less redundant display of recurrence in issue view.
bec8599
@cryptogopher
Status message includes next scheduled recurrence info.
0ca472a
@cryptogopher
Eliminated 'show' view.
6774c50 
It duplicated informations shown in issue view and forced one more
click to get to recurrence edition (inefficient).
@cryptogopher
Removing 'show' view continued...
c0f1a84
@cryptogopher
Changed UI design/action link placement.
2e876c0 
Modified recurrence listing in issue view. Updated look to better match Redmine.
@cryptogopher
Little tweaks and cleanup.
b7e138c
@cryptogopher
Further visual changes.
ef7b8fe
@cryptogopher
Changed task generation condition.
7d2da1b 
New recurrence is generated as soon as previous recurrence date is reached.
This way new recurrence date is known in greatest possible advance (instead
of just 1 day as before). This is important for proper planning of task
execution.
@cryptogopher
Fixed error in /recurring_tasks (when no project is selected).
c2132a1
@cryptogopher
Issue view: empty when no recurrences and header pluralized.
9f1ca05
@cryptogopher
Fixed cron configuration example.
9ab33ee
@cryptogopher
Migration: setting default modifier for existing monthly issues.
09180d1
@cryptogopher
Replaced "yes" with tick mark in recurrence index.
41c4aaf
nutso
nutso reviewed Jul 4, 2014
View reviewed changes
README.md
@@ -26,7 +26,7 @@ You should now be able to see the plugin list in Administration -> Plugins.

Crontab example (running the check for recurrence every 6 hours):
```bash
* */4 * * * /bin/sh "cd {path_to_redmine} && rake RAILS_ENV=production redmine:recur_tasks" >> log/cron_rake.log 2>&1
27 */4 * * * /bin/sh "cd {path_to_redmine} && rake RAILS_ENV=production redmine:recur_tasks" >> log/cron_rake.log 2>&1
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand the impact of this change to the reader -- do you think it makes the crontab format more obvious?

@nutso
Copy link
Owner

nutso commented Jul 4, 2014

Thanks for contributing, and apologies for taking so long to reply. I added some notes on the changes, and will be more prompt in responding in the future.

"added support for modified month occurrences (e.g. "on 10th day before month end", "on second Tuesday of month")"
==> This is awesome.

"removed "show" recurrence view. In my opinion it was duplicating what has already been shown in "issue" view and added unnecessary one more click to get to "edit" view."
==> Understood, and leaving the 'show' view in there to allow for future functionality that will likely not be displayed in the 'issue' view. Can probably add a link to 'edit' directly to allow for a more streamlined user experience.

'modified task generation process (invoked through cron) to create next recurrence as soon as previous recurrence day is reached. This way next task recurrence is known in advance (not 1 day before its due date as before). It is important to allow planning issue execution efficiently in real life.'
==> This makes it difficult to 'cancel' a recurrence. My intent is to add functionality to 'group' all like recurrences together, in which case the cancelling will know which future tasks to remove.

'partly changed UI design to better match native Redmine look and allow more efficient usage of plugin, other minor changes'
==> OK, much of this seemed like six of one and a half-dozen of another =)

Thanks again.

@nutso nutso self-assigned this Jul 4, 2014
@ittomsk
Copy link

ittomsk commented Sep 2, 2014

Looking forward to a soon merge of that code into the main branch.

nutso added a commit that referenced this pull request Sep 7, 2014
@nutso
#41 merged pull request from @cryptogopher into develop branch, with …
bf967fc 
…modifications as noted on the pull request
@nutso
Copy link
Owner

nutso commented Sep 7, 2014

Integrated into develop and merged as part of pull request #47

@nutso nutso closed this Sep 7, 2014
@nutso nutso added this to the v1.4.0 milestone Jun 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nutso nutso

Labels
enhancement
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cryptogopher @nutso @ittomsk