Skip to content

fix(devtools-kit): explicitly type return type of useDevtoolsHostClient #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

huang-julien
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

TS or Rollup isn't able to detect the return type of useDevtoolsHostClient so we have to sstrongly type it

image

Copy link

Deploying nuxt-devtools with Β Cloudflare Pages Β Cloudflare Pages

Latest commit: d966d20
Status:Β βœ…Β  Deploy successful!
Preview URL: https://64c87ace.nuxt-devtools.pages.dev
Branch Preview URL: https://fix-usedevtoolshostclienttyp.nuxt-devtools.pages.dev

View logs

@antfu antfu merged commit 161e847 into main May 13, 2025
2 of 3 checks passed
@antfu antfu deleted the fix/useDevtoolsHostClienttype branch May 13, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants