ci: run vite build to test playground #2624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying ui3 with Β
|
| Latest commit: |
23849e7
|
| Status: | Β β Β Deploy successful! |
| Preview URL: | https://b99d207f.ui-6q2.pages.dev |
| Branch Preview URL: | https://ci-vue-build.ui-6q2.pages.dev |
commit: |
| "typecheck": "vue-tsc --noEmit && nuxi typecheck playground && nuxi typecheck docs && nuxi typecheck devtools && cd playground-vue && vue-tsc --noEmit", | ||
| "test": "vitest", | ||
| "test:vue": "vitest -c vitest.vue.config.ts", | ||
| "test:vue:build": "vite build playground-vue", |
There was a problem hiding this comment.
Wouldn't it be better to run the actual build command to set it fail? π€
Something like "pnpm --filter 'playground-vue' build"
There was a problem hiding this comment.
indeed, ultimately we should probably also run a type checking step but this pr just verifies that the vue app can build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
This ensures it's possible to build a vue app using
@nuxt/uiπ Checklist