Skip to content

Diagnostics Not Updated When Tree Not Visible #2519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alex-courtis opened this issue Nov 6, 2023 Discussed in #2517 · 2 comments
Closed

Diagnostics Not Updated When Tree Not Visible #2519

alex-courtis opened this issue Nov 6, 2023 Discussed in #2517 · 2 comments
Labels
bug Something isn't working reproduced Issue confirmed

Comments

@alex-courtis
Copy link
Member

Discussed in #2517

Originally posted by juhaku November 7, 2023
Hey,

I'd like a support for functionality where the diagnostics status and what not would be updated / reloaded upon NvimTree reveal? Is that currently possible? I did not see any configuration option that would enable such thing.

EDIT: There is nvim-tree.auto_reload_on_write that allows tree to update while being opened and a file is being written to. Also there is tree.reload() API that is tied to R command command and reload_on_bufenter configuration flag but non of these seem to give remedy to the situation. Like hitting R button does not seem to affect much to the state of the tree at least the diagnostics does not get updated. Same happens no matter I travel between different buffers. The only way for diagnostics to actually get updated seems to be by way of writing on buffer while keeping the NvimTree open.

-Juha

@alex-courtis alex-courtis added bug Something isn't working reproduced Issue confirmed labels Nov 6, 2023
@alex-courtis
Copy link
Member Author

Thanks for finding this one @juhaku

Diagnostic events are being received whilst the tree is closed however the nodes are not being updated:

[2023-11-07 10:32:58] [diagnostics] DiagnosticChanged
[2023-11-07 10:32:58] [diagnostics] DiagnosticChanged

Should see

[2023-11-07 10:33:40] [diagnostics] DiagnosticChanged
[2023-11-07 10:33:40] [profile] START diagnostics update
[2023-11-07 10:33:40] [diagnostics] update
...

@juhaku
Copy link

juhaku commented Nov 6, 2023

Anytime 🙂

iusmac added a commit to iusmac/nvim-tree.lua that referenced this issue Dec 22, 2023
iusmac added a commit to iusmac/nvim-tree.lua that referenced this issue Dec 23, 2023
iusmac added a commit to iusmac/nvim-tree.lua that referenced this issue Dec 23, 2023
iusmac added a commit to iusmac/nvim-tree.lua that referenced this issue Dec 23, 2023
alex-courtis added a commit that referenced this issue Dec 30, 2023
* fix(#2519): diagnostics overhaul

Signed-off-by: iusmac <[email protected]>

* fix: Properly filter diagnostics from coc

Also, while we're at it, refactor the lsp function for consistency.
There should be no functional change, just cosmetic.

Signed-off-by: iusmac <[email protected]>

* Assign diagnostic version per node to reduce overhead

Signed-off-by: iusmac <[email protected]>

* Require renderer once

Signed-off-by: iusmac <[email protected]>

* Revert "Require renderer once"

Causes circular requires after the previous commit.

This reverts commit 7413041.

* Rename `buffer_severity_dict` to `BUFFER_SEVERITY`

Signed-off-by: iusmac <[email protected]>

* Log diagnostics update properly

Signed-off-by: iusmac <[email protected]>

* Implement error handling for coc.nvim

Signed-off-by: iusmac <[email protected]>

* CI style fixes

Signed-off-by: iusmac <[email protected]>

* Capture `Keyboard interrupt` when handling coc exceptions

Signed-off-by: iusmac <[email protected]>

* add more doc

---------

Signed-off-by: iusmac <[email protected]>
Co-authored-by: Alexander Courtis <[email protected]>
alex-courtis added a commit that referenced this issue Jan 6, 2024
alex-courtis added a commit that referenced this issue Jan 7, 2024
alex-courtis added a commit that referenced this issue Jan 7, 2024
alex-courtis added a commit that referenced this issue Jan 20, 2024
…ight-overhaul (#2455)

* feat(#2415): granular highlight_diagnostics, normalise groups (#2454)

* chore: normalise colours and enable cterm (#2471)

* feat(#2415): granular highlight_git, normalise git groups (#2487)

* docs: update CONTRIBUTING.md (#2485)

* feat(#2415): granular highlight_git, normalise git groups

* feat(#2415): normalise and add modified groups

* feat(#2415): create Decorator class for modified and bookmarks

* feat(#2415): create DecoratorDiagnostics

* feat(#2415): create DecoratorGit

* feat(#2415): create DecoratorGit

* add DecoratorCopied DecoratorCut

* add DecoratorOpened

* remove unloaded_bufnr checks as the view debouncer takes care of it

* Add `renderer.highlight_git` to accepted strings

* fix(#2415): builder refactor (#2538)

* simplify builder signs

* decorators take care of themselves and are priority ordered

* simplify builder hl groups

* refactor builder for icon arrays

* builder use decorators generically

* fix(#2415): harden sign creation (#2539)

* fix(#2415): harden unicode signs

* Decorator tidy

* normalise git sign creation and tidy

* tidy builder

* NvimTreeBookmarkIcon

* tidy HL doc

* tidy HL doc

* tidy HL doc

* tidy builder doc

* standardise on '---@param'

* DiagnosticWarning -> DiagnosticWarn

* annotate decorators

* limit to two highlight groups for line rendering

* style

* apply #2519

* feat(#2415): combined hl groups (#2601)

* feat(#2415): create combined highlight groups

* feat(#2415): create combined highlight groups

* feat(#2415): create combined highlight groups

* ci: allow workflow_dispatch (#2620)

* one and only one hl namespace, required winhl removal

* small tidies

* colors.lua -> appearance.lua

* full-name uses one and only namespace

* don't highlight fast, just apply to namespace, safer win_set_hl

* gut builder (#2622)

collapse Builder

* fix group_empty function check

* feat(#2415): highlight-overhaul release date

---------

Co-authored-by: Akmadan23 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working reproduced Issue confirmed
Projects
None yet
Development

No branches or pull requests

2 participants