Skip to content

chore: use builtin EmmyLuaCodeStyle for style checking #3084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Mar 23, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "chore: use luals for style check"
This reverts commit e5fde80.
  • Loading branch information
alex-courtis committed Mar 22, 2025
commit 9d93eb6c81b0fb1a82f51b7d64847e2015cd6d4b
42 changes: 17 additions & 25 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,30 +34,30 @@ jobs:

- run: make lint

# style:
# runs-on: ubuntu-latest
style:
runs-on: ubuntu-latest

# concurrency:
# group: ${{ github.workflow }}-${{ matrix.emmy_lua_code_style_version }}-${{ github.head_ref || github.ref_name }}
# cancel-in-progress: true
concurrency:
group: ${{ github.workflow }}-${{ matrix.emmy_lua_code_style_version }}-${{ github.head_ref || github.ref_name }}
cancel-in-progress: true

# strategy:
# matrix:
# luals_version: [ 3.13.9 ]
strategy:
matrix:
luals_version: [ 3.13.9 ]

# steps:
# - uses: actions/checkout@v4
steps:
- uses: actions/checkout@v4

# - name: install luals
# run: |
# mkdir -p luals
# curl -L "https://github.com/LuaLS/lua-language-server/releases/download/${{ matrix.luals_version }}/lua-language-server-${{ matrix.luals_version }}-linux-x64.tar.gz" | tar zx --directory luals
- name: install luals
run: |
mkdir -p luals
curl -L "https://github.com/LuaLS/lua-language-server/releases/download/${{ matrix.luals_version }}/lua-language-server-${{ matrix.luals_version }}-linux-x64.tar.gz" | tar zx --directory luals

# - run: echo "luals/bin" >> "$GITHUB_PATH"
- run: echo "luals/bin" >> "$GITHUB_PATH"

# - run: make style
- run: make style

# - run: make style-doc
- run: make style-doc

check:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -92,11 +92,3 @@ jobs:
run: make check

- run: make help-check

- name: make style
env:
VIMRUNTIME: /home/runner/nvim-${{ matrix.nvim_version }}/share/nvim/runtime
run: make style

- run: make style-doc