Use new directives on x86 #3931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
spiessimon
force-pushed
the
new-directives-in-x86
branch
3 times, most recently
from
ac3d617 to
1775d6a
Compare
spiessimon
force-pushed
the
new-directives-in-x86
branch
from
1775d6a to
fb842d5
Compare
This was referenced Apr 30, 2025
mshinwell
requested changes
May 7, 2025
mshinwell
approved these changes
May 8, 2025
spiessimon
added a commit
that referenced
this pull request
May 9, 2025
This reverts commit 66a06b9.
spiessimon
added a commit
that referenced
this pull request
May 9, 2025
This was referenced May 9, 2025
spiessimon
added a commit
to spiessimon/flambda-backend
that referenced
this pull request
May 23, 2025
spiessimon
added a commit
that referenced
this pull request
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the existing code for emitting directives on x86 with the new directives. The changes that were observed in the emitted assembly code are summarized in this PR (#3932).