Document [row_more] #3934
Merged
Document [row_more] #3934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Discussed with Jacques and submitted ocaml/ocaml#14023 upstream. Will update this PR with the result of that review in due course; changing this to a draft in the meantime. |
lpw25
reviewed
May 12, 2025
There was a problem hiding this comment.
I think this only describes some of what is going on with row_more. Describing what it actually means seems hard, so I'd suggest having the comment only describe the 3 possible cases and which types would produce them, without commenting on what row_more actually is beyond that.
goldfirere
force-pushed
the
rae/doc-row-more
branch
from
249fa6c to
37f8f19
Compare
|
The version here was accepted upstream. Shall we merge here too? |
lpw25
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe I now understand
row_more, and this commit invites others into my recently-entered elysium.Review: @lpw25
EDIT: See my next comment; no need for review.