Fix runtime5 on macOS x86 #4008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshinwell
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to tweak a couple files to get runtime5 building on my 2019 Intel MacBook Pro.
In signals.c, I put
max_size_tbehind an#ifdef __linux__since it's only used in an#ifdef __linux__block below.In signals_nat.c, I modified some code manipulating an
mcontext_tin accordance with runtime4/signals_osdep.h and put it behind an#ifdef SYS_macosx.With these changes, I was able to build and install the compiler with
--enable-runtime5.