Fortran misc edits to conform to dir struc and naming #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ron Green <[email protected]>
anjgola
previously approved these changes
Aug 7, 2020
There was a problem hiding this comment.
LGTM. I think We should get another Fortran samples expert to review these as well. @greenrongreen Any recommendations?
I have requested Barbara Perz to review |
JoeOster
changed the title
|
The title for this is still labelled as 'WIP' hence not merging. Please update title to indicate readiness. |
JoeOster
reviewed
Aug 20, 2020
DirectProgramming/Fortran/CombinationalLogic/openmp-primes/README.md
Outdated
Show resolved
Hide resolved
JoeOster
reviewed
Aug 20, 2020
DirectProgramming/Fortran/DenseLinearAlgebra/optimize-integral/README.md
Show resolved
Hide resolved
JoeOster
reviewed
Aug 20, 2020
DirectProgramming/Fortran/DenseLinearAlgebra/optimize-integral/README.md
Show resolved
Hide resolved
JoeOster
reviewed
Aug 20, 2020
DirectProgramming/Fortran/DenseLinearAlgebra/optimize-integral/README.md
Show resolved
Hide resolved
JoeOster
reviewed
Aug 20, 2020
DirectProgramming/Fortran/DenseLinearAlgebra/vectorize-vecmatmult/README.md
Outdated
Show resolved
Hide resolved
JoeOster
requested changes
Aug 20, 2020
There was a problem hiding this comment.
Barbara reviewed and made a few comments, Ron should be making changes accordingly
- The samples all run fine. Directions are good.
- Change main sample root directory oneAPI-samples/DirectProgramming/Fortran/vec_samples
to main sample root directory oneAPI-samples/DirectProgramming/Fortran/DenseLinearAlgebra/vectorize-vecmatmult - here’s a Makefile in the dir, but the README.md doesn’t say to use it. The other samples state to use the Makefile.
JoeOster
changed the title
|
Pushed fixes from Review by Barbara Perz. |
JoeOster
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All 3 samples have dir name changes to match samples standard. README.md all 3 updated with Title change to reflect the directory names.